Hello,
I have the following commit that fixes typos:
https://github.com/Silex/mipsdk-samples-component/commit/8bd4daaf353d5b2ef3ff9cbfc5c4fa46c75eb790
I cannot start a PR because you limited the upstream repository for collaborators only.
Either add “Silex” as a collaborator so I can start a PR or simply take that commit and do what you want with it.
You rock, @Philippe Vaucher ! I’ll make sure our SDK team see this and hopefully open the repos up for PR’s. Thanks for your effort!
Hi Philippe,
Thanks a lot for providing this. It is the intention eventually to open up for external PRs, but unfortunately we are not entirely there yet.
I will make sure we include your changes in the next release.
Thanks again!
/Peter
Ok if you guys are receptive I might make more commits.
There’s also typos in the DB, for example:
ALTER TABLE [dbo].[Sites] ADD CONSTRAINT [SITES_VERISON_DEFAULT] DEFAULT ('') FOR [Version]
“VERISON” instead of “VERSION”
Hi Philippe,
Thanks again. We will look through those and incorporate in the next release (2021 R1).
Regarding database we’ll probably leave that for now, since it is not meant for public reading anyways.
Kr,
Peter